link3280 commented on code in PR #5134:
URL: https://github.com/apache/kyuubi/pull/5134#discussion_r1302986220
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -1319,6 +1319,15 @@ object KyuubiConf {
.intConf
.createWithDefault(1000000)
+ val ENGINE_FLINK_FETCH_TIMEOUT: OptionalConfigEntry[Long] =
+ buildConf("kyuubi.session.engine.flink.fetch.timeout")
+ .doc("Result fetch timeout for Flink engine. If the timeout is reached,
the result " +
+ "fetch would be stopped and the current fetched would be returned. If
no data are " +
+ "fetched, a TimeoutException would be thrown.")
+ .version("1.8.0")
+ .timeConf
+ .createOptional
Review Comment:
I found `kyuubi.operation.query.timeout` uses `None`.
https://github.com/apache/kyuubi/blob/9e3ac23df71302c5b87dab206cdf96f42811035e/kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala#L1851-L1863
Plus, I think `0` sometimes denotes an immediate timeout instead of an
infinite timeout, thus `None` is a better choice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
