zhuyaogai commented on code in PR #5182:
URL: https://github.com/apache/kyuubi/pull/5182#discussion_r1306385954
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -2614,6 +2614,17 @@ object KyuubiConf {
.toSequence()
.createWithDefault(Nil)
+ val SERVER_LIMIT_CONNECTIONS_USER_LIMITED_LIST: ConfigEntry[Seq[String]] =
+ buildConf("kyuubi.server.limit.connections.user.limited.list")
+ .doc("The user in the limited list will be limited to connect to kyuubi
server, " +
+ "if the user has configured both user.unlimited.list and
user.limited.list, " +
+ "the priority of the latter is higher.")
+ .version("1.8.0")
+ .serverOnly
+ .stringConf
+ .toSequence()
Review Comment:
I think we don't need to check any limit in `decrement` method, and let the
already opened sessions decrement limit counter. Please correct me if I am
wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
