pan3793 commented on issue #5212:
URL: https://github.com/apache/kyuubi/issues/5212#issuecomment-1702568494
Seems we can make the following change.
```patch
server:
...
- prometheus:
- enabled: true
- port: 10019
- service:
- type: ClusterIP
- port: "{{ .Values.server.prometheus.port }}"
- nodePort: ~
- annotations: {}
...
+ monitoring:
+ prometheus:
+ enabled: true
+ port: 10019
- metricsReporters: ~
```
- move `prometheus` node from `server` to `monitoring` as @dnskr suggested
- `metricsReporters` could be inferred from `monitoring`'s keys in runtime
thus we can remove it from the `values.yaml`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
