pan3793 commented on code in PR #5243:
URL: https://github.com/apache/kyuubi/pull/5243#discussion_r1315020898
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiBatchService.scala:
##########
@@ -83,14 +82,9 @@ class KyuubiBatchService(
metadata.className,
metadata.requestConf,
metadata.requestArgs,
- Some(metadata), // TODO some logic need to fix since it's not
from recovery
+ Some(metadata),
+ false,
shouldRunAsync = true)
- val metadataForUpdate = Metadata(
- identifier = batchId,
- kyuubiInstance = kyuubiInstance,
- requestConf = batchSession.optimizedConf,
- clusterManager =
batchSession.batchJobSubmissionOp.builder.clusterManager())
- metadataManager.updateMetadata(metadataForUpdate,
asyncRetryOnError = false)
Review Comment:
the logic moved to `KyuubiBatchSession#open`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
