bowenliang123 commented on code in PR #5251:
URL: https://github.com/apache/kyuubi/pull/5251#discussion_r1318028306
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -1427,6 +1427,14 @@ object KyuubiConf {
.timeConf
.createWithDefault(Duration.ofSeconds(15).toMillis)
+ val ENGINE_ALIVE_MAX_FAIL_COUNT: ConfigEntry[Int] =
+ buildConf("kyuubi.session.engine.alive.max.fail.count")
Review Comment:
How about changing the config name to
`kyuubi.session.engine.alive.max.failures` , following the style of existed
config `kyuubi.engine.deregister.job.max.failures` ? The word `count` doesn't
contribute much semantic meaning for definition or usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
