pan3793 commented on code in PR #3590:
URL: https://github.com/apache/kyuubi/pull/3590#discussion_r1011139391
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkSQLEngine.scala:
##########
@@ -168,6 +168,8 @@ object SparkSQLEngine extends Logging {
if (Utils.isOnK8s) {
kyuubiConf.setIfMissing(FRONTEND_CONNECTION_URL_USE_HOSTNAME, false)
+ val podNamePrefix = s"kyuubi-${user}-${Instant.now().toEpochMilli}"
Review Comment:
@hanna-liashchuk, it introduces a regression if `user` contains char which
not allowed in
https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#dns-subdomain-names
```
java.lang.IllegalArgumentException: 'kyuubi-bdms_pancheng-1667361024618' in
spark.kubernetes.executor.podNamePrefix is invalid. must conform
https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#dns-subdomain-names
and the value length <= 237
at
org.apache.spark.internal.config.TypedConfigBuilder.$anonfun$checkValue$1(ConfigBuilder.scala:108)
~[spark-core_2.12-3.3.1.1.jar:3.3.1.1]
at
org.apache.spark.internal.config.TypedConfigBuilder.$anonfun$transform$1(ConfigBuilder.scala:101)
~[spark-core_2.12-3.3.1.1.jar:3.3.1.1]
at scala.Option.map(Option.scala:230) ~[scala-library-2.12.15.jar:?]
at
org.apache.spark.internal.config.OptionalConfigEntry.readFrom(ConfigEntry.scala:239)
~[spark-core_2.12-3.3.1.1.jar:3.3.1.1]
at
org.apache.spark.internal.config.OptionalConfigEntry.readFrom(ConfigEntry.scala:214)
~[spark-core_2.12-3.3.1.1.jar:3.3.1.1]
at org.apache.spark.SparkConf.get(SparkConf.scala:261)
~[spark-core_2.12-3.3.1.1.jar:3.3.1.1]
at
org.apache.spark.deploy.k8s.KubernetesConf.get(KubernetesConf.scala:70)
~[spark-kubernetes_2.12-3.3.1.1.jar:3.3.1.1]
at
org.apache.spark.deploy.k8s.KubernetesExecutorConf.<init>(KubernetesConf.scala:156)
~[spark-kubernetes_2.12-3.3.1.1.jar:3.3.1.1]
at
org.apache.spark.deploy.k8s.KubernetesConf$.createExecutorConf(KubernetesConf.scala:246)
~[spark-kubernetes_2.12-3.3.1.1.jar:3.3.1.1]
at
org.apache.spark.scheduler.cluster.k8s.ExecutorPodsAllocator.$anonfun$requestNewExecutors$1(ExecutorPodsAllocator.scala:394)
~[spark-kubernetes_2.12-3.3.1.1.jar:3.3.1.1]
at scala.collection.immutable.Range.foreach$mVc$sp(Range.scala:158)
~[scala-library-2.12.15.jar:?]
at
org.apache.spark.scheduler.cluster.k8s.ExecutorPodsAllocator.requestNewExecutors(ExecutorPodsAllocator.scala:387)
~[spark-kubernetes_2.12-3.3.1.1.jar:3.3.1.1]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
