pan3793 commented on code in PR #5196:
URL: https://github.com/apache/kyuubi/pull/5196#discussion_r1324958176
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/ProcBuilder.scala:
##########
@@ -320,9 +321,14 @@ trait ProcBuilder {
.orElse {
// 2. get from $KYUUBI_HOME/externals/kyuubi-download/target
env.get(KYUUBI_HOME).flatMap { p =>
- val candidates = Paths.get(p, "externals", "kyuubi-download",
"target")
- .toFile.listFiles(homeDirFilter)
- if (candidates == null) None else candidates.map(_.toPath).headOption
+ Paths.get(p, "externals", "kyuubi-download", "target").toFile
+ .listFiles(homeDirFilter)
Review Comment:
How about pulling `val homeDirFilter` out so that we can overwrite the
scala-2.13's SPARK_HOME detection in `SparkProcessBuilder`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
