pan3793 commented on PR #5303: URL: https://github.com/apache/kyuubi/pull/5303#issuecomment-1722879807
Generally, the integration test is required on adding new dialect to JDBC engine to ensure the implementation correctness. https://github.com/apache/kyuubi/blob/3cf5a20b7a9b1e58764a1ada981cb5a68b69e70e/integration-tests/kyuubi-jdbc-it/src/test/scala/org/apache/kyuubi/it/jdbc/doris/OperationWithServerSuite.scala And please fill in the PR description, such information is VERY important to an open-source project for community cooperation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
