pan3793 commented on code in PR #5305:
URL: https://github.com/apache/kyuubi/pull/5305#discussion_r1328475961
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/BatchesResource.scala:
##########
@@ -415,6 +415,16 @@ private[v1] class BatchesResource extends
ApiRequestContext with Logging {
} else if (fe.connectionUrl != metadata.kyuubiInstance) {
val internalRestClient =
getInternalRestClient(metadata.kyuubiInstance)
internalRestClient.getBatchLocalLog(userName, batchId, from, size)
+ } else if (batchV2Enabled(metadata.requestConf) &&
+ // Aims to cover the case that batch job been picked by current
instance
+ // but the batch id not been handled by this SessionManager.
+ // Ref to we open session first then hand the session
+ // and mark operation RUNNING also has code gap with handler session,
+ // we consider RUNNING state too
Review Comment:
```suggestion
// in batch v2 impl, the operation state is changed from PENDING
to RUNNING
// before being added to SessionManager.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
