pan3793 commented on code in PR #5306:
URL: https://github.com/apache/kyuubi/pull/5306#discussion_r1329743545
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/YarnApplicationOperation.scala:
##########
@@ -21,118 +21,144 @@ import java.util.Locale
import scala.collection.JavaConverters._
+import org.apache.hadoop.conf.Configuration
import org.apache.hadoop.yarn.api.records.{FinalApplicationStatus,
YarnApplicationState}
import org.apache.hadoop.yarn.client.api.YarnClient
-import org.apache.kyuubi.Logging
+import org.apache.kyuubi.{Logging, Utils}
import org.apache.kyuubi.config.KyuubiConf
+import org.apache.kyuubi.config.KyuubiConf.YARNClientProxyUserStrategy
+import org.apache.kyuubi.config.KyuubiConf.YARNClientProxyUserStrategy._
import org.apache.kyuubi.engine.ApplicationOperation._
import org.apache.kyuubi.engine.ApplicationState.ApplicationState
import org.apache.kyuubi.engine.YarnApplicationOperation.toApplicationState
import org.apache.kyuubi.util.KyuubiHadoopUtils
class YarnApplicationOperation extends ApplicationOperation with Logging {
- @volatile private var yarnClient: YarnClient = _
+ private var yarnConf: Configuration = _
+ @volatile private var adminYarnClient: Option[YarnClient] = None
private var submitTimeout: Long = _
override def initialize(conf: KyuubiConf): Unit = {
submitTimeout = conf.get(KyuubiConf.ENGINE_YARN_SUBMIT_TIMEOUT)
- val yarnConf = KyuubiHadoopUtils.newYarnConfiguration(conf)
- // YarnClient is thread-safe
- val c = YarnClient.createYarnClient()
- c.init(yarnConf)
- c.start()
- yarnClient = c
- info(s"Successfully initialized yarn client: ${c.getServiceState}")
+ yarnConf = KyuubiHadoopUtils.newYarnConfiguration(conf)
+
+
YARNClientProxyUserStrategy.withName(conf.get(KyuubiConf.YARN_PROXY_USER_STRATEGY))
match {
+ case NONE =>
+ val c = createYarnClient(yarnConf)
+ info(s"Successfully initialized admin YARN client.")
+ adminYarnClient = Some(c)
+ case ADMIN =>
+ val adminUser =
conf.get(KyuubiConf.YARN_PROXY_USER_ADMIN_USER).getOrElse(Utils.currentUser)
+ Utils.doAs(adminUser) { () =>
+ val c = createYarnClient(yarnConf)
+ info(s"Successfully initialized admin YARN client with user:
$adminUser.")
+ adminYarnClient = Some(c)
+ }
+ case OWNER =>
+ info("Skip initializing admin YARN client")
+ }
}
- override def isSupported(appMgrInfo: ApplicationManagerInfo): Boolean = {
- yarnClient != null && appMgrInfo.resourceManager.exists(
- _.toLowerCase(Locale.ROOT).startsWith("yarn"))
+ private def createYarnClient(_yarnConf: Configuration): YarnClient = {
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
