bowenliang123 commented on code in PR #5196:
URL: https://github.com/apache/kyuubi/pull/5196#discussion_r1350317498
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/spark/SparkProcessBuilder.scala:
##########
@@ -337,9 +337,9 @@ object SparkProcessBuilder {
final private[kyuubi] val sparkCoreScalaVersionRegex =
Review Comment:
sure.
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/spark/SparkProcessBuilder.scala:
##########
@@ -337,9 +337,9 @@ object SparkProcessBuilder {
final private[kyuubi] val sparkCoreScalaVersionRegex =
"""^spark-core_(\d\.\d+).*.jar$""".r
- final private[kyuubi] val homeRegexForScala212 =
+ final private[kyuubi] lazy val SPARK_HOME_REGEX_SCALA_212 =
"""^spark-\d+\.\d+\.\d+-bin-hadoop\d+(\.\d+)?$""".r
- final private[kyuubi] val homeRegexForScala213 =
+ final private[kyuubi] lazy val SPARK_HOME_REGEX_SCALA_213 =
Review Comment:
fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
