bowenliang123 commented on code in PR #5287:
URL: https://github.com/apache/kyuubi/pull/5287#discussion_r1351476944


##########
extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/OperationType.scala:
##########
@@ -21,7 +21,7 @@ object OperationType extends Enumeration {
 
   type OperationType = Value
 
-  val ALTERDATABASE, ALTERDATABASE_LOCATION, ALTERTABLE_ADDCOLS, 
ALTERTABLE_ADDPARTS,
+  val ALTERDATABASE, ALTERDATABASE_LOCATION, ALTERTABLE, ALTERTABLE_ADDCOLS, 
ALTERTABLE_ADDPARTS,

Review Comment:
   Prevent Introducing new OperationType if there are not enough reasons.
   Authz plugin follows the Ranger's Hive policy style and  the operation type 
refers to  upstream Ranger Hive plugin's 
`RangerHiveOperationType`(https://github.com/apache/ranger/blob/ranger-2.3/hive-agent/src/test/java/org/apache/ranger/services/hive/RangerHiveOperationType.java)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to