pan3793 commented on code in PR #5352:
URL: https://github.com/apache/kyuubi/pull/5352#discussion_r1356025409
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/jdbc/JDBCMetadataStoreConf.scala:
##########
@@ -93,4 +93,16 @@ object JDBCMetadataStoreConf {
.serverOnly
.stringConf
.createWithDefault("")
+
+ val METADATA_STORE_JDBC_PRIORITY_ENABLED: ConfigEntry[Boolean] =
+ buildConf("kyuubi.metadata.store.jdbc.priority.enabled")
+ .doc("Whether to enable picking up jobs from the metadata store in order
of priority." +
+ "If this feature is disabled, setting kyuubi.batch.priority will not
take effect." +
+ "However, it is recommended to enable this feature if you already have
a metadata store " +
+ "that can support mixed order indexing(such as MySQL 8)." +
+ "See why recommend this in https://github.com/apache/kyuubi/pull/5329";)
Review Comment:
suggested change:
Whether to enable the priority scheduling for batch impl v2. When false,
ignore `kyuubi.batch.priority` and use the FIFO ordering strategy for batch job
scheduling. Note: it's recommended to use MySQL 8.0 as metadata backend, since
this feature may cause significant performance issues when using MySQL 5.7 due
to the lack of support for mixed order index. See more details at KYUUBI #5329.
Also, please take care of the space between each line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
