bowenliang123 commented on PR #5287: URL: https://github.com/apache/kyuubi/pull/5287#issuecomment-1759096892
> > Please add a new PrivilegesBuilderSuite for Hudi as well. The `IcebergCatalogPrivilegesBuilderSuite` could be an example. New supported commands should be covered in both end-to-end tests in `*RangerSparkExtensionSuite` and the privilege object parsing tests in `*PrivilegesBuilderSuite`. The latter is important for maintaining compatibility and ensuring the intermediates. > > Hudi is working on supporting v2 command. Currently, CREATE DATABASE does not support v2 command, so this place may not be able to test it yet. Maybe we only can add some test for the command that support v2 Well notices. But the concern is we should have a PrivilegesBuilderSuite for Hudi. It doesn't matter if Hudi only works on V1 only as you discovered. WDYT? Is it possible to create a Hudi's PrivilegesBuilderSuite or maybe there's other way to test the intermediates previlge objects? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
