wForget commented on code in PR #4916:
URL: https://github.com/apache/kyuubi/pull/4916#discussion_r1357665415
##########
extensions/spark/kyuubi-spark-authz/src/test/scala/org/apache/kyuubi/plugin/spark/authz/ranger/IcebergCatalogRangerSparkExtensionSuite.scala:
##########
@@ -106,12 +113,10 @@ class IcebergCatalogRangerSparkExtensionSuite extends
RangerSparkExtensionSuite
withSingleCallEnabled {
val e2 = intercept[AccessControlException](
doAs(
- someone,
+ bob,
sql(mergeIntoSql)))
assert(e2.getMessage.contains(s"does not have" +
- s" [select] privilege" +
- s" on
[$namespace1/$table1/id,$namespace1/table1/name,$namespace1/$table1/city]," +
- s" [update] privilege on [$namespace1/$outputTable1]"))
+ s" [update] privilege on [$bobNamespace/$bobSelectTable]"))
}
Review Comment:
There is subQuery in the `mergeIntoSql` execution plan in Spark 3.5. When
applying the `OptimizeSubqueries` rule, it returns no select permission and no
update. If we want to verify `withSingleCallEnabled` I think we need to use
other statements, like: `insert into ... select ...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
