yaooqinn commented on code in PR #5287:
URL: https://github.com/apache/kyuubi/pull/5287#discussion_r1360287679


##########
extensions/spark/kyuubi-spark-authz/pom.xml:
##########
@@ -336,6 +336,23 @@
     </build>
 
     <profiles>
+        <!--
+          Add hudi profile here to avoid import Hudi when enable scala-2.13.
+          Can remove this profile after hudi support Scala 2.13.
+          https://issues.apache.org/jira/browse/HUDI-6296
+          -->
+        <profile>
+            <id>hudi</id>

Review Comment:
   > What do you think about adding a empty hudi profile at the root pom.xml 
with the comments
   
   Unlike platform-like dependencies, such as JDK, Scala, etc., keeping the 
profile id as simple as possible might be good.
   For others, less sharable among clients, servers, and plugins, keeping them 
as informative and specific as possible sounds good to me.
   
   Also, I'm not against unifying them when they are ready to be merged as a 
more general one or two. 
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to