wForget commented on code in PR #5410:
URL: https://github.com/apache/kyuubi/pull/5410#discussion_r1361442452
##########
externals/kyuubi-spark-sql-engine/src/test/scala/org/apache/spark/kyuubi/SQLOperationListenerSuite.scala:
##########
@@ -22,16 +22,37 @@ import
scala.collection.JavaConverters.asScalaBufferConverter
import org.apache.hive.service.rpc.thrift.{TExecuteStatementReq,
TFetchOrientation, TFetchResultsReq, TOperationHandle}
import org.scalatest.time.SpanSugar._
+import org.apache.kyuubi.config.KyuubiConf
import org.apache.kyuubi.config.KyuubiConf.OPERATION_SPARK_LISTENER_ENABLED
import org.apache.kyuubi.engine.spark.WithSparkSQLEngine
import org.apache.kyuubi.operation.HiveJDBCTestHelper
class SQLOperationListenerSuite extends WithSparkSQLEngine with
HiveJDBCTestHelper {
- override def withKyuubiConf: Map[String, String] = Map.empty
+ override def withKyuubiConf: Map[String, String] = Map(
+ KyuubiConf.ENGINE_SPARK_SHOW_PROGRESS.key -> "true",
Review Comment:
Yes, we can improve it in subsequent PRs, please take a look at
https://github.com/apache/kyuubi/pull/5410#discussion_r1360160628 and use a
faster sql instead of `java_method('java.lang. Thread', 'sleep', 10000l)`, like
```
select /*+ REPARTITION(3, a) */ a from values(1) t(a);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
