biangjuang commented on code in PR #5412:
URL: https://github.com/apache/kyuubi/pull/5412#discussion_r1361531851
##########
kyuubi-zookeeper/src/main/scala/org/apache/kyuubi/zookeeper/EmbeddedZookeeper.scala:
##########
@@ -51,7 +57,7 @@ class EmbeddedZookeeper extends
AbstractService("EmbeddedZookeeper") {
}
try {
- zks = new ZooKeeperServer(dataDirectory, dataDirectory, tickTime)
+ zks = new ZooKeeperServer(dataDirectory, dataLogDirectory, tickTime)
Review Comment:
> would you mind addressing this issue in a separated PR?
yes，done by #5440
##########
kyuubi-zookeeper/src/main/scala/org/apache/kyuubi/zookeeper/EmbeddedZookeeper.scala:
##########
@@ -51,7 +57,7 @@ class EmbeddedZookeeper extends
AbstractService("EmbeddedZookeeper") {
}
try {
- zks = new ZooKeeperServer(dataDirectory, dataDirectory, tickTime)
+ zks = new ZooKeeperServer(dataDirectory, dataLogDirectory, tickTime)
Review Comment:
> would you mind addressing this issue in a separated PR?
yes，done by #5440
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
