yaooqinn commented on PR #5439: URL: https://github.com/apache/kyuubi/pull/5439#issuecomment-1765721168
Hi @AngersZhuuuu, would you please also attach the signatures of these hudi classes in the PR description? Reviewers might have less knowledge about hudi than you. I noticed that it helped me a lot during code review. For example, https://github.com/apache/hudi/blob/master/hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/CreateHoodieTableCommand.scala Also cc @bowenliang123 @packyan @pan3793 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
