Yikf commented on code in PR #5427:
URL: https://github.com/apache/kyuubi/pull/5427#discussion_r1361995532
##########
extensions/spark/kyuubi-spark-authz/pom.xml:
##########
@@ -331,6 +331,60 @@
<directory>${project.basedir}/src/test/resources</directory>
</testResource>
</testResources>
+
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <configuration>
+ <shadedArtifactAttached>false</shadedArtifactAttached>
+ <artifactSet>
+ <includes>
+
<include>org.apache.kyuubi:kyuubi-util-scala_${scala.binary.version}</include>
+ <include>org.apache.kyuubi:kyuubi-util</include>
+
<include>org.apache.ranger:ranger-plugins-common</include>
+
<include>org.apache.ranger:ranger-plugins-audit</include>
+
<include>org.codehaus.jackson:jackson-jaxrs</include>
Review Comment:
Now, it only leaks `jna` related classes, and since jna contains so, it
seems that it cannot be relocated.
Also, ranger-related classes do not require relocation, which does not
change how the user is released.
I think this type of package has almost no class conflict issues, so it
seems that this is ok too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
