bowenliang123 commented on code in PR #5398:
URL: https://github.com/apache/kyuubi/pull/5398#discussion_r1363318093
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/operation/ExecuteStatement.scala:
##########
@@ -159,7 +164,15 @@ class ExecuteStatement(
override protected def runInternal(): Unit = {
executeStatement()
val sessionManager = session.sessionManager
- val asyncOperation: Runnable = () => waitStatementComplete()
+ val asyncOperation: Runnable = () =>
+ try {
+ if (isTimeoutMonitorEnabled) {
+ addTimeoutMonitor(queryTimeout)
Review Comment:
It's done on purpose for considering and tolerating the time for connecting
and submitting statement to the engine.
But let's move it before `executeStatement` this time for semantic
consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
