bowenliang123 commented on code in PR #5473:
URL: https://github.com/apache/kyuubi/pull/5473#discussion_r1365863929
##########
extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/PrivilegesBuilder.scala:
##########
@@ -102,6 +103,15 @@ object PrivilegesBuilder {
val cols = conditionList ++ aggCols
buildQuery(a.child, privilegeObjects, projectionList, cols, spark)
+ case pvm: PermanentViewMarker =>
+ getScanSpec(pvm).tables(pvm, spark).foreach { table =>
+ if (pvm.child.output.isEmpty) {
+ privilegeObjects += PrivilegeObject(table,
pvm.catalogTable.schema.map(_.name))
Review Comment:
Sounds like it's asking for the privilege on all the columns of the table.
But what if a user with privilege on single or part of columns, and this
would prevent him from counting the table.
WDYT ? @yaooqinn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
