bowenliang123 commented on code in PR #5497:
URL: https://github.com/apache/kyuubi/pull/5497#discussion_r1368367393
##########
kyuubi-util-scala/src/main/scala/org/apache/kyuubi/util/reflect/ReflectUtils.scala:
##########
@@ -92,14 +88,8 @@ object ReflectUtils {
}
} catch {
case e: Exception =>
- val candidates =
- (clz.getDeclaredMethods ++ clz.getMethods)
- .map(m =>
s"${m.getName}(${m.getParameterTypes.map(_.getName).mkString(", ")})")
- .distinct.sorted
- val argClassesNames = argClasses.map(_.getName)
throw new RuntimeException(
- s"Method $methodName(${argClassesNames.mkString(", ")})" +
- s" not found in $clz [${candidates.mkString(", ")}]",
+ s"$clz does not have $methodName method or incorrect arguments",
Review Comment:
I suggest to keep the method signature
`$methodName(${argClassesNames.mkString(", ")})` for further investigation. As
for skipping candidates, LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
