yaooqinn commented on code in PR #5476:
URL: https://github.com/apache/kyuubi/pull/5476#discussion_r1368701301
##########
extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/ranger/RuleApplyPermanentViewMarker.scala:
##########
@@ -39,12 +39,16 @@ class RuleApplyPermanentViewMarker extends
Rule[LogicalPlan] {
case permanentView: View if hasResolvedPermanentView(permanentView) =>
val resolvedSubquery = permanentView.transformAllExpressions {
case subquery: SubqueryExpression =>
- // TODO: Currently, we do not do an auth check in the subquery
- // as the main query part also secures it. But for performance
consideration,
- // we also pre-check it in subqueries and fail fast with negative
privileges.
- subquery.withNewPlan(plan = PermanentViewMarker(subquery.plan,
null))
+ subquery.withNewPlan(plan =
+ PermanentViewMarker(
+ subquery.plan,
+ permanentView.desc,
+ permanentView.output.map(_.name)))
}
- PermanentViewMarker(resolvedSubquery, resolvedSubquery.desc)
+ PermanentViewMarker(
+ resolvedSubquery,
Review Comment:
nit: it's not resolvedSubquery but a view?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
