bowenliang123 commented on code in PR #5506:
URL: https://github.com/apache/kyuubi/pull/5506#discussion_r1369637597
##########
extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/serde/tableExtractors.scala:
##########
@@ -246,10 +246,10 @@ class HudiDataSourceV2RelationTableExtractor extends
TableExtractor {
invokeAs[LogicalPlan](v1, "table") match {
// Match multipartIdentifier with tableAlias
case SubqueryAlias(_, SubqueryAlias(identifier, _)) =>
- new StringTableExtractor().apply(spark, identifier.toString())
+ lookupExtractor[StringTableExtractor].apply(spark,
identifier.toString())
Review Comment:
The extractor does not own a state. And they are more like snippets that
cooperate together for object extractions, so we are reusing them rather than
creating an instance inside another. No much heavier in code lines and has less
memory footprint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
