yaooqinn commented on code in PR #5515:
URL: https://github.com/apache/kyuubi/pull/5515#discussion_r1369940876
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/session/SessionManager.scala:
##########
@@ -312,8 +312,7 @@ abstract class SessionManager(name: String) extends
CompositeService(name) {
try {
closeSession(session.handle)
} catch {
- case e: KyuubiSQLException =>
- warn(s"Error closing idle session ${session.handle}", e)
+ case e: Throwable => warn(s"Error closing idle session
${session.handle}", e)
Review Comment:
Use NonFatal here, exceptions like InterruptedException shall stay AS-IS？
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/session/SessionManager.scala:
##########
@@ -312,8 +312,7 @@ abstract class SessionManager(name: String) extends
CompositeService(name) {
try {
closeSession(session.handle)
} catch {
- case e: KyuubiSQLException =>
- warn(s"Error closing idle session ${session.handle}", e)
+ case e: Throwable => warn(s"Error closing idle session
${session.handle}", e)
Review Comment:
Use NonFatal here, exceptions like InterruptedException shall stay AS-IS？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
