AngersZhuuuu commented on code in PR #5504:
URL: https://github.com/apache/kyuubi/pull/5504#discussion_r1372602231
##########
extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/PrivilegesBuilder.scala:
##########
@@ -122,6 +122,13 @@ object PrivilegesBuilder {
buildQuery(child, privilegeObjects, projectionList, conditionList,
spark)
}
}
+
+ // Should execute this for all plan and skip PermanentViewMaker
Review Comment:
Yea, no need to skip since it din't have an expression and we won't call
`buildQuery` for its child.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
