pan3793 commented on code in PR #5548:
URL: https://github.com/apache/kyuubi/pull/5548#discussion_r1374136906
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/ui/JettyServer.scala:
##########
@@ -71,14 +74,20 @@ private[kyuubi] case class JettyServer(
def getState: String = server.getState
}
-object JettyServer {
+object JettyServer extends Logging{
- def apply(name: String, host: String, port: Int, poolSize: Int): JettyServer
= {
+ def apply(name: String, host: String, port: Int, kyuubiConf: KyuubiConf):
JettyServer = {
+
+ // set Jetty Server pool size
Review Comment:
the comment usually should be a supplement to the code block which is
composed of complex logic. And a good comment explains WHY should we do but not
WHAT we are doing, because in most cases, the code is clear enough to answer
the latter question
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
