AngersZhuuuu commented on code in PR #5540:
URL: https://github.com/apache/kyuubi/pull/5540#discussion_r1374701549
##########
extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/ranger/RuleAuthorization.scala:
##########
@@ -41,7 +43,7 @@ class RuleAuthorization(spark: SparkSession) extends
Rule[LogicalPlan] {
object RuleAuthorization {
- val KYUUBI_AUTHZ_TAG = TreeNodeTag[Boolean]("__KYUUBI_AUTHZ_TAG")
+ val KYUUBI_AUTHZ_TAG = TreeNodeTag[Unit]("__KYUUBI_AUTHZ_TAG")
Review Comment:
> LGTM overall, except that using Unit as the holing value type for the tag.
I would prefer the original one with Boolean type. WDYT? @yaooqinn
Hmmm @yaooqinn ask to change this place.....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
