pan3793 commented on code in PR #5564:
URL: https://github.com/apache/kyuubi/pull/5564#discussion_r1376095758
##########
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/auth/KerberosAuthentication.java:
##########
@@ -96,13 +97,15 @@ private static KerberosPrincipal
createKerberosPrincipal(String principal) {
}
}
- private static Configuration createLoginFromTgtCacheConfiguration() {
+ private static Configuration createLoginFromTgtCacheConfiguration(String
ticketCache) {
ImmutableMap.Builder<String, String> optionsBuilder =
ImmutableMap.<String, String>builder()
.put("useTicketCache", "true")
.put("renewTGT", "true");
- String ticketCache = System.getenv("KRB5CCNAME");
+ if (StringUtils.isBlank(ticketCache)) {
+ ticketCache = System.getenv("KRB5CCNAME");
+ }
if (ticketCache != null) {
Review Comment:
use isNotBlank for consistent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
