zml1206 commented on PR #5567: URL: https://github.com/apache/kyuubi/pull/5567#issuecomment-1785711721
> Why CreateDeltaTableCommand is useless? > > Nit: for PR description and code comments, explain **WHY** is more important than **WHAT**, since the code usually is clear enough for reviewer to understand what you are doing. Before, I misunderstood the role of `table_command_spec.json` in #5529 ,The logical plans for Delta Lake create table and replace table are `org.apache.spark.sql.catalyst.plans.logical.CreateTable` and `org.apache.spark.sql.catalyst.plans.logical.CreateV2Table` and `org. apache.spark.sql.catalyst.plans.logical.ReplaceTable`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
