zwangsheng commented on code in PR #5587:
URL: https://github.com/apache/kyuubi/pull/5587#discussion_r1378325023
##########
kyuubi-server/web-ui/src/layout/components/aside/index.vue:
##########
@@ -37,6 +37,11 @@
const { isCollapse } = storeToRefs(store)
const router = useRoute()
const activePath = ref(router.path)
+ /* eslint-disable */
+ // define __APP_VERSION__ in vite.config.ts
+ // @ts-ignore
+ const title = `Apache Kyuubi\n${__APP_VERSION__}`
Review Comment:
May this fit expection?
##########
kyuubi-server/web-ui/src/layout/components/aside/index.vue:
##########
@@ -37,6 +37,11 @@
const { isCollapse } = storeToRefs(store)
const router = useRoute()
const activePath = ref(router.path)
+ /* eslint-disable */
+ // define __APP_VERSION__ in vite.config.ts
+ // @ts-ignore
+ const title = `Apache Kyuubi\n${__APP_VERSION__}`
Review Comment:
May this fit expection?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
