YesOrNo828 commented on code in PR #5585:
URL: https://github.com/apache/kyuubi/pull/5585#discussion_r1381032760
##########
externals/kyuubi-flink-sql-engine/src/test/scala/org/apache/kyuubi/engine/flink/operation/FlinkOperationSuite.scala:
##########
@@ -1265,4 +1266,14 @@ abstract class FlinkOperationSuite extends
HiveJDBCTestHelper with WithFlinkTest
})
assert(exception.getMessage === "Futures timed out after [60000
milliseconds]")
}
+
+ test("execute statement - help") {
+ withJdbcStatement() { stmt =>
+ val resultSet = stmt.executeQuery("help")
+ val metadata = resultSet.getMetaData
+ assert(metadata.getColumnName(1) === "result")
+ assert(resultSet.next())
+ assert(resultSet.getString(1).equals(CliStrings.MESSAGE_HELP.toString))
Review Comment:
Yes, I think you're right. This `CliStrings.MESSAGE_HELP` message is
described in the Flink SQL Client. CLEAR and QUIT/EXIT are not supported for
Beeline.
How about we define the help message in the Flink Engine? Removing the CLEAR
and QUIT/EXIT command descriptions may be a little tricky from
`CliStrng.MESSAGE_HELP`. We could also add some new descriptions, for example:
show jobs, stop job 'job_id', create Table, drop table, etc. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
