bowenliang123 commented on code in PR #5645:
URL: https://github.com/apache/kyuubi/pull/5645#discussion_r1385806999
##########
extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/serde/CommandSpec.scala:
##########
@@ -57,7 +57,8 @@ trait CommandSpecs[T <: CommandSpec] {
case class DatabaseCommandSpec(
classname: String,
databaseDescs: Seq[DatabaseDesc],
- opType: String = "QUERY") extends CommandSpec {}
+ opType: String = "QUERY",
+ uriDescs: Seq[UriDesc] = Nil) extends CommandSpec {}
Review Comment:
```suggestion
uriDescs: Seq[UriDesc] = Nil,
opType: String = "QUERY") extends CommandSpec {}
```
Shall we keep the order in `descs` for different kinds and followed by the
`opType`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
