wForget commented on code in PR #5591:
URL: https://github.com/apache/kyuubi/pull/5591#discussion_r1387351552
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/operation/ExecuteStatement.scala:
##########
@@ -159,6 +160,25 @@ class ExecuteStatement(
override def iterator: Iterator[Any] =
incrementalCollectResult(resultDF)
})
} else {
+ val sparkSave =
spark.conf.getOption(OPERATION_RESULT_SAVE_TO_FILE.key).map(_.toBoolean)
+
.getOrElse(session.sessionManager.getConf.get(OPERATION_RESULT_SAVE_TO_FILE))
+ lazy val threshold =
+
session.sessionManager.getConf.get(OPERATION_RESULT_SAVE_TO_FILE_THRESHOLD)
+ if (hasResultSet && sparkSave && shouldSaveResultToHdfs(resultMaxRows,
threshold, result)) {
Review Comment:
`shouldSaveResultToHdfs` is inferred based on the execution plan and may not
be accurate. Should we change it to `sparkSave || shouldSaveResultToHdfs`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
