zml1206 commented on code in PR #5666:
URL: https://github.com/apache/kyuubi/pull/5666#discussion_r1390585225
##########
extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/serde/tableExtractors.scala:
##########
@@ -144,9 +146,12 @@ class ResolvedTableTableExtractor extends TableExtractor {
*/
class IdentifierTableExtractor extends TableExtractor {
override def apply(spark: SparkSession, v1: AnyRef): Option[Table] = {
- val namespace = invokeAs[Array[String]](v1, "namespace")
- val table = invokeAs[String](v1, "name")
- Some(Table(None, Some(quote(namespace)), table, None))
+ val identifier = v1.asInstanceOf[Identifier]
+ if (PathIdentifier.isPathIdentifier(identifier)) {
Review Comment:
What is the reason for removing `hasDeltaNamespace(namespace)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
