zwangsheng commented on code in PR #5695:
URL: https://github.com/apache/kyuubi/pull/5695#discussion_r1393690183
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/EngineRef.scala:
##########
@@ -187,7 +202,7 @@ private[kyuubi] class EngineRef(
conf.set(KYUUBI_ENGINE_SUBMIT_TIME_KEY, String.valueOf(started))
builder = engineType match {
case SPARK_SQL =>
- conf.setIfMissing(SparkProcessBuilder.APP_KEY, defaultEngineName)
+ conf.set(SparkProcessBuilder.APP_KEY,
generateAppKey(conf.getOption(SparkProcessBuilder.APP_KEY).getOrElse(null)))
Review Comment:
IMO, if user set spark app name, we should not over write this, so we should
keep setIfMissing here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
