pan3793 commented on code in PR #5711:
URL: https://github.com/apache/kyuubi/pull/5711#discussion_r1395771457
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -1239,6 +1239,21 @@ object KyuubiConf {
.booleanConf
.createWithDefault(false)
+ val KUBERNETES_APPLICATION_STATE_FROM_CONTAINER: ConfigEntry[Boolean] =
+ buildConf("kyuubi.kubernetes.application.state.fromContainer")
+ .doc("If set to true then the application state will be retrieved from
the container " +
+ "instead of the pod.")
+ .version("1.8.1")
+ .booleanConf
+ .createWithDefault(false)
+
+ val KUBERNETES_APPLICATION_STATE_CONTAINER: ConfigEntry[String] =
+ buildConf("kyuubi.kubernetes.application.state.container")
+ .doc("The container names to retrieve the application state from.")
Review Comment:
there are bunches of tricks under the hood, users may not get enough
information from such a brief description.
e.g. in which conditions, this configuration takes effect? how to set the
value(e.g. it must be same as xxx)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
