zml1206 commented on code in PR #5706:
URL: https://github.com/apache/kyuubi/pull/5706#discussion_r1404102539
##########
extensions/spark/kyuubi-spark-authz/src/test/scala/org/apache/kyuubi/plugin/spark/authz/gen/DeltaCommands.scala:
##########
@@ -41,25 +42,29 @@ object DeltaCommands extends CommandSpecs[TableCommandSpec]
{
val MergeIntoCommand = {
val cmd = "org.apache.spark.sql.delta.commands.MergeIntoCommand"
+ val actionTypeDesc = ActionTypeDesc(actionType = Some(UPDATE))
+ val tableDesc = TableDesc(
+ "target",
+ classOf[SubqueryAliasTableExtractor],
+ actionTypeDesc = Some(actionTypeDesc),
+ comment = "Delta")
val queryDesc = QueryDesc("source")
- DeleteCommand.copy(classname = cmd, queryDescs = Seq(queryDesc))
+ TableCommandSpec(cmd, Seq(tableDesc), queryDescs = Seq(queryDesc))
}
val OptimizeTableCommand = {
val cmd = "org.apache.spark.sql.delta.commands.OptimizeTableCommand"
- val childDesc = TableDesc("child", classOf[ResolvedTableTableExtractor])
- val tableDesc = TableDesc("tableId",
classOf[TableIdentifierOptionTableExtractor])
- val uriDescs = Seq(
- UriDesc("child", classOf[ResolvedTableURIExtractor]),
- UriDesc("tableId", classOf[TableIdentifierOptionURIExtractor]),
- UriDesc("path", classOf[StringURIExtractor]))
- TableCommandSpec(cmd, Seq(childDesc, tableDesc), ALTERTABLE_COMPACT,
uriDescs = uriDescs)
+ val childDesc = TableDesc("child", classOf[ResolvedTableTableExtractor],
comment = "Delta")
+ val tableDesc =
+ TableDesc("tableId", classOf[TableIdentifierOptionTableExtractor],
comment = "Delta")
+ TableCommandSpec(cmd, Seq(childDesc, tableDesc), ALTERTABLE_COMPACT)
Review Comment:
```
val OptimizeTableCommand = {
val cmd = "org.apache.spark.sql.delta.commands.OptimizeTableCommand"
val childDesc = TableDesc("child", classOf[ResolvedTableTableExtractor],
comment = "Delta")
val tableDesc = TableDesc("tableId",
classOf[TableIdentifierOptionTableExtractor], comment = "Delta")
val uriDescs = Seq(
UriDesc("child", classOf[ResolvedTableURIExtractor]),
UriDesc("tableId", classOf[TableIdentifierOptionURIExtractor]),
UriDesc("path", classOf[StringURIExtractor]))
TableCommandSpec(cmd, Seq(childDesc, tableDesc), ALTERTABLE_COMPACT,
uriDescs = uriDescs)
}
```
##########
extensions/spark/kyuubi-spark-authz/src/test/scala/org/apache/kyuubi/plugin/spark/authz/gen/DeltaCommands.scala:
##########
@@ -41,25 +42,29 @@ object DeltaCommands extends CommandSpecs[TableCommandSpec]
{
val MergeIntoCommand = {
val cmd = "org.apache.spark.sql.delta.commands.MergeIntoCommand"
+ val actionTypeDesc = ActionTypeDesc(actionType = Some(UPDATE))
+ val tableDesc = TableDesc(
+ "target",
+ classOf[SubqueryAliasTableExtractor],
+ actionTypeDesc = Some(actionTypeDesc),
+ comment = "Delta")
val queryDesc = QueryDesc("source")
- DeleteCommand.copy(classname = cmd, queryDescs = Seq(queryDesc))
+ TableCommandSpec(cmd, Seq(tableDesc), queryDescs = Seq(queryDesc))
Review Comment:
```
val MergeIntoCommand = {
val cmd = "org.apache.spark.sql.delta.commands.MergeIntoCommand"
val queryDesc = QueryDesc("source")
DeleteCommand.copy(classname = cmd, queryDescs = Seq(queryDesc))
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
