Re: [PR] [KYUUBI #5680] Optimize Spark engine pod name generation [kyuubi]

Sun, 03 Dec 2023 18:19:18 -0800 


Ocean22 commented on PR #5695:
URL: https://github.com/apache/kyuubi/pull/5695#issuecomment-1837734060

   > > how about this?
   > > ```diff
   > > - private def getResourceNamePrefix(appName: String, engineRefId: 
String): String = {
   > > -   s"$appName-$engineRefId"
   > > + private def getResourceNamePrefix(appName: String, engineRefId: 
Option[String]): String = {
   > > +   engineRefId.map(refId => s"$appName-$refId").getOrElse(appName)
   > > ```
   > 
   > Is it right what I modified? 
![image](https://private-user-images.githubusercontent.com/45907917/285113782-de40fdaf-be75-4ea3-98cc-414f92305a79.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTEiLCJleHAiOjE3MDE2NTQ4MTYsIm5iZiI6MTcwMTY1NDUxNiwicGF0aCI6Ii80NTkwNzkxNy8yODUxMTM3ODItZGU0MGZkYWYtYmU3NS00ZWEzLTk4Y2MtNDE0ZjkyMzA1YTc5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFJV05KWUFYNENTVkVINTNBJTJGMjAyMzEyMDQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjMxMjA0VDAxNDgzNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTliNWFhMzk2NjA2MmRlYjc4Njk2MDg2ZjQzODZmOTI4YTcxODFiOTFlODdlZDI3ZmQ3ZGQ1YzY0M2ZlZTFkMzYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.37in7esdfpzyAviZ3UlZegcv52Mzf5XlVP0WCPIvHho)
   
   @pan3793 Hi,the code passed the test,and it's the result
   
![企业微信截图_17016561025430](https://github.com/apache/kyuubi/assets/45907917/4fdc69f7-22f6-4a73-a5c6-73b1c2a71a19)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to