bowenliang123 commented on code in PR #5812:
URL: https://github.com/apache/kyuubi/pull/5812#discussion_r1413393408
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/schema/RowSet.scala:
##########
@@ -169,12 +169,13 @@ object RowSet {
var idx = 0
while (idx < size) {
val row = rows(idx)
- val isNull = row.isNullAt(ordinal)
+ val value = row.get(ordinal)
+ val isNull = value == null
Review Comment:
1. No changes here, as the Spark's `row.isNullAt` checks the value equals to
`null` of Java precisely
2. Thanks for hint. The default implementation of Row IS array-based.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
