pan3793 opened a new pull request, #28:
URL: https://github.com/apache/kyuubi-shaded/pull/28
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in
https://github.com/apache/kyuubi/issues, add '[KYUUBI-SHADED #XXXX]' in your PR
title, e.g., '[KYUUBI-SHADED #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][KYUUBI-SHADED #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
This PR aims to tackle https://github.com/apache/kyuubi-shaded/pull/10 with
another approach.
Though we can add the snappy deps into ZK client 3.6 to address it, as the
snappy has native libs that are not able to be relocated, thus there will be
potential conflict issues, this approach also increases the size of
`kyuubi-relocated-zookeeper-3.6`.
Actually, `org.apache.zookeeper.server.persistence.SnapStream` is only used
on the server side, in terms of Kyuubi's usage, the embedded ZK feature is
mostly for testing purposes, overwriting the `SnapStream` to drop the Snappy
support should be OK.
To gain a clear change history, I purpose to split the change into 2 PRs,
1. copy `org.apache.zookeeper.server.persistence.SnapStream` from [Apache
Zookeeper
v3.6.4](https://raw.githubusercontent.com/apache/zookeeper/release-3.6.4/zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/SnapStream.java)
as-is
2. removing the Snappy support (simply throw
`UnsupportedOperationException`) in
`org.apache.zookeeper.server.persistence.SnapStream` and snappy deps
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including
negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run
test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests)
locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
