bowenliang123 commented on PR #5815: URL: https://github.com/apache/kyuubi/pull/5815#issuecomment-1840060090
> @bowenliang123 I guess the overhead may come from the always construction of `HiveResult.getTimeFormatters` Yes. For most cases, shown from evidence. But the overhead for primitive types should not comes from the data types, the time formatters are reused in the whole stage of TRowSet generation. Still have to see more evidence for repeated tests. Please consider merge #5809 to introduce benchmark with warmups and repeating rounds, for the reference of further investigation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
