YesOrNo828 commented on code in PR #5821:
URL: https://github.com/apache/kyuubi/pull/5821#discussion_r1417090260


##########
docs/configuration/settings.md:
##########
@@ -177,6 +178,7 @@ You can configure the Kyuubi properties in 
`$KYUUBI_HOME/conf/kyuubi-defaults.co
 | kyuubi.engine.spark.python.env.archive                   | <undefined> 
        | Portable Python env archive used for Spark engine Python language 
mode.                                                                           
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                          
                                                       | string   | 1.7.0 |
 | kyuubi.engine.spark.python.env.archive.exec.path         | bin/python        
        | The Python exec path under the Python env archive.                    
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                      
                                                       | string   | 1.7.0 |
 | kyuubi.engine.spark.python.home.archive                  | <undefined> 
        | Spark archive containing $SPARK_HOME/python directory, which is used 
to init session Python worker for Python language mode.                         
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                       
                                                       | string   | 1.7.0 |
+| kyuubi.engine.spark.initialize.sql                       |                   
        | the initialize sql for spark engine. it it fallback to  
`kyuubi.engine.session.initialize.sql`                                          
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                    
                                                       | seq      | 1.8.1 |

Review Comment:
   ```suggestion
   | kyuubi.engine.spark.initialize.sql                       |                 
          | The initialize sql for spark engine. It fallback to  
`kyuubi.engine.initialize.sql`                                                  
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                     
                                              | seq      | 1.8.1 |
   ```



##########
docs/configuration/settings.md:
##########
@@ -142,6 +142,7 @@ You can configure the Kyuubi properties in 
`$KYUUBI_HOME/conf/kyuubi-defaults.co
 | kyuubi.engine.flink.extra.classpath                      | <undefined> 
        | The extra classpath for the Flink SQL engine, for configuring the 
location of hadoop client jars, etc. Only effective in yarn session mode.       
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                          
                                                       | string   | 1.6.0 |
 | kyuubi.engine.flink.java.options                         | <undefined> 
        | The extra Java options for the Flink SQL engine. Only effective in 
yarn session mode.                                                              
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                         
                                                       | string   | 1.6.0 |
 | kyuubi.engine.flink.memory                               | 1g                
        | The heap memory for the Flink SQL engine. Only effective in yarn 
session mode.                                                                   
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                           
                                                       | string   | 1.6.0 |
+| kyuubi.engine.flink.initialize.sql                       |                   
        | the initialize sql for flink engine. it fallback to  
`kyuubi.engine.initialize.sql`.                                                 
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                       
                                                       | seq      | 1.8.1 |

Review Comment:
   ```suggestion
   | kyuubi.engine.flink.initialize.sql                       |                 
          | The initialize sql for flink engine. It fallback to  
`kyuubi.engine.initialize.sql`.                                                 
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                     
                                                         | seq      | 1.8.1 |
   ```



##########
docs/configuration/settings.md:
##########
@@ -429,6 +431,7 @@ You can configure the Kyuubi properties in 
`$KYUUBI_HOME/conf/kyuubi-defaults.co
 | kyuubi.session.engine.flink.fetch.timeout            | <undefined>     
  | Result fetch timeout for Flink engine. If the timeout is reached, the 
result fetch would be stopped and the current fetched would be returned. If no 
data are fetched, a TimeoutException would be thrown.                           
                                                                                
                                                                                
                    | duration | 1.8.0 |
 | kyuubi.session.engine.flink.main.resource            | <undefined>     
  | The package used to create Flink SQL engine remote job. If it is undefined, 
Kyuubi will use the default                                                     
                                                                                
                                                                                
                                                                                
             | string   | 1.4.0 |
 | kyuubi.session.engine.flink.max.rows                 | 1000000               
  | Max rows of Flink query results. For batch queries, rows exceeding the 
limit would be ignored. For streaming queries, the query would be canceled if 
the limit is reached.                                                           
                                                                                
                                                                                
                    | int      | 1.5.0 |
+| kyuubi.session.engine.flink.initialize.sql           |                       
  | the initialize sql for flink session.it fallback to  
`kyuubi.engine.session.initialize.sql`.                                         
                                                                                
                                                                                
                                                                                
                                    | seq      | 1.8.1 |

Review Comment:
   ```suggestion
   | kyuubi.session.engine.flink.initialize.sql           |                     
    | The initialize sql for Flink session. It fallback to 
`kyuubi.engine.session.initialize.sql`.                                         
                                                                                
                                                                                
                                                                                
                                    | seq      | 1.8.1 |
   ```



##########
docs/configuration/settings.md:
##########
@@ -444,6 +447,7 @@ You can configure the Kyuubi properties in 
`$KYUUBI_HOME/conf/kyuubi-defaults.co
 | kyuubi.session.engine.spark.progress.timeFormat      | yyyy-MM-dd 
HH:mm:ss.SSS | The time format of the progress bar                              
                                                                                
                                                                                
                                                                                
                                                                                
                        | string   | 1.6.0 |
 | kyuubi.session.engine.spark.progress.update.interval | PT1S                  
  | Update period of progress bar.                                              
                                                                                
                                                                                
                                                                                
                                                                                
             | duration | 1.6.0 |
 | kyuubi.session.engine.spark.showProgress             | false                 
  | When true, show the progress bar in the Spark's engine log.                 
                                                                                
                                                                                
                                                                                
                                                                                
             | boolean  | 1.6.0 |
+| kyuubi.session.engine.spark.initialize.sql           |                       
  | the initialize sql for spark session. it fallback to  
`kyuubi.engine.session.initialize.sql`                                          
                                                                                
                                                                                
                                                                                
                                   | seq      | 1.8.1 |

Review Comment:
   ```suggestion
   | kyuubi.session.engine.spark.initialize.sql           |                     
    | The initialize sql for spark session. It fallback to 
`kyuubi.engine.session.initialize.sql`.                                         
                                                                                
                                                                                
                                                                                
                                    | seq      | 1.8.1 |
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to