cfmcgrady commented on code in PR #5811:
URL: https://github.com/apache/kyuubi/pull/5811#discussion_r1417512241
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/schema/RowSet.scala:
##########
@@ -24,15 +24,17 @@ import scala.collection.JavaConverters._
import org.apache.hive.service.rpc.thrift._
import org.apache.spark.sql.Row
import org.apache.spark.sql.execution.HiveResult
+import org.apache.spark.sql.execution.HiveResult.{getTimeFormatters,
TimeFormatters}
import org.apache.spark.sql.types._
import org.apache.kyuubi.util.RowSetUtils._
object RowSet {
- def toHiveString(valueAndType: (Any, DataType), nested: Boolean = false):
String = {
- // compatible w/ Spark 3.1 and above
- val timeFormatters = HiveResult.getTimeFormatters
Review Comment:
I think the reason that the time formatter is created each time is because
the session time zone can be modified by querying `set
spark.sql.session.timeZone=<new time zone>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
