bowenliang123 commented on code in PR #5811:
URL: https://github.com/apache/kyuubi/pull/5811#discussion_r1418405291
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/sql/kyuubi/SparkDatasetHelper.scala:
##########
@@ -103,19 +104,20 @@ object SparkDatasetHelper extends Logging {
timestampAsString: Boolean): DataFrame = {
val quotedCol = (name: String) => col(quoteIfNeeded(name))
+ val tf = getTimeFormatters
Review Comment:
> > Shall we roll back to create TimeFormatters inside
`convertTopLevelComplexTypeToHiveString`, if `HiveResult.getTimeFormatters` is
probably not thread-safe ?
>
> In that case, we could just do an adjustment like this
>
> ```
> RowSet.toHiveString((row, st), nested = true, timeFormatters =
getTimeFormatters)
> ```
OK, let's put it in this style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
