pan3793 commented on code in PR #5831:
URL: https://github.com/apache/kyuubi/pull/5831#discussion_r1419911173
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/schema/RowSet.scala:
##########
@@ -97,12 +98,14 @@ object RowSet {
val timeFormatters = HiveResult.getTimeFormatters
var i = 0
val columnSize = schema.length
+ val tColumns = new java.util.ArrayList[TColumn](columnSize)
Review Comment:
nit: usually we use `util.ArrayList` or `JArrayList` to reference Java
collection classes
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/schema/RowSet.scala:
##########
@@ -97,12 +98,14 @@ object RowSet {
val timeFormatters = HiveResult.getTimeFormatters
var i = 0
val columnSize = schema.length
+ val tColumns = new java.util.ArrayList[TColumn](columnSize)
Review Comment:
nit: usually we use `util.ArrayList` or `JArrayList` in Scala code to
reference Java collection classes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
