panbingkun commented on PR #5874: URL: https://github.com/apache/kyuubi/pull/5874#issuecomment-1862056417
> LGTM in changes overall. However external manual validation on a forked Spark repo may not be enough. Last time I reverted similar changes in #5840 and abandoned drafted #5843, exactly due to assuming things right with skipped validation in PR. After `Spark Merge it`, I verified again whether it is normal, and it is currently normal. eg: https://github.com/apache/spark/actions/runs/7255705397/job/19766796815?pr=43924 <img width="1209" alt="image" src="https://github.com/apache/kyuubi/assets/15246973/3a93fc1a-b8e2-4c91-bb93-e5cae242e3f2";> If it is not enough, I can verify the exact logic of `` and `` files in `my private repo` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
