cxzl25 commented on code in PR #5887: URL: https://github.com/apache/kyuubi/pull/5887#discussion_r1433427201
########## kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala: ########## @@ -287,10 +287,10 @@ class KyuubiSessionImpl( } @volatile private var engineLastAlive: Long = _ - val engineAliveTimeout = sessionConf.get(KyuubiConf.ENGINE_ALIVE_TIMEOUT) - val aliveProbeEnabled = sessionConf.get(KyuubiConf.ENGINE_ALIVE_PROBE_ENABLED) - var engineAliveMaxFailCount = 3 - var engineAliveFailCount = 0 + private val engineAliveTimeout = sessionConf.get(KyuubiConf.ENGINE_ALIVE_TIMEOUT) + private val aliveProbeEnabled = sessionConf.get(KyuubiConf.ENGINE_ALIVE_PROBE_ENABLED) + private val engineAliveMaxFailCount = 3 Review Comment: Sorry, my mistake may be that I picked branch 1.8 and did not push it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
