pan3793 commented on code in PR #5882:
URL: https://github.com/apache/kyuubi/pull/5882#discussion_r1433629198
##########
externals/kyuubi-jdbc-engine/src/main/scala/org/apache/kyuubi/engine/jdbc/mysql/Mysql8ConnectionProvider.scala:
##########
@@ -22,10 +22,14 @@ class Mysql8ConnectionProvider extends
JdbcConnectionProvider {
override val name: String = classOf[Mysql8ConnectionProvider].getSimpleName
- override val driverClass: String = "com.mysql.cj.jdbc.Driver"
+ override val driverClass: String = Mysql8ConnectionProvider.driverClass
override def canHandle(providerClass: String): Boolean = {
driverClass.equalsIgnoreCase(providerClass)
}
}
+
+object Mysql8ConnectionProvider {
Review Comment:
```suggestion
object MySQL8ConnectionProvider {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
